feat: Replace SimpleMediaAgent with OutcomeAgent implementation#19
Draft
nastassiafulconis wants to merge 4 commits intomainfrom
Draft
feat: Replace SimpleMediaAgent with OutcomeAgent implementation#19nastassiafulconis wants to merge 4 commits intomainfrom
nastassiafulconis wants to merge 4 commits intomainfrom
Conversation
- Implement OutcomeAgent with MCP protocol integration - Add get_proposals tool for proposal generation with product filtering and budget optimization - Add accept_proposal tool for assignment acceptance with validation - Replace simple-media-agent binary with outcome-agent binary - Add comprehensive test coverage (32 tests: 15 for get-proposals, 17 for accept-proposal) - Add npm script: start:outcome-agent - Update exports to include OutcomeAgent and related types BREAKING CHANGE: SimpleMediaAgent has been removed. Use OutcomeAgent instead. The binary name has changed from simple-media-agent to outcome-agent. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Resolved conflicts: - package.json: Kept both outcome-agent and scope3 CLI binaries - package-lock.json: Regenerated after merge Merged changes from main: - Added CLI tool (scope3 binary) - Updated README and documentation - Added test scripts 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
49da498 to
cdf4e3c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR replaces the
SimpleMediaAgentwith a newOutcomeAgentimplementation based on the Scope3 Outcome Agent Protocol specification.Changes
✅ Implemented
src/outcome-agent.ts)outcome-agent(replacessimple-media-agent)npm run start:outcome-agent🗑️ Removed
simple-media-agentbinary📦 Updated
simple-media-agenttooutcome-agentBreaking Changes
simple-media-agenttooutcome-agentTesting
npm testAll tests passing: ✅ 32 tests (17 accept-proposal, 15 get-proposals)
How to Run
Implementation Notes
console.errorfor logging because stdout is reserved for MCP protocol communicationChecklist
🤖 Generated with Claude Code